Improve test perfomance granularity2 #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a performance test more connections may be opened then is allowed by the OS - and that will make more errors when the program tries to close the connection that is not open. This way only close connections that got open.
This limits how many bisect steps the backtrack tries before getting a result then doing a performance test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #68
We had reperformance issues and decided to install a new server to replace the old one. When testing the new server I wanted hard number to compare between the installations, but the new server was so much better that the testsubmit.py failed in new ways:
The program then misbehaved when trying to close the connections that was not open.
Solution: only close the connection if the there is a connection.
Solution: Add timeout for the tests, and add how many bisect steps should be tried to get highest good number.
Regards