Handle 'phased rollout already finished' error

tramlinehq · Oct 17, 2024 · e20e30e · e20e30e
1 parent 845b6eb
commit e20e30e
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 7 deletions.
diff --git a/lib/app_store/errors.rb b/lib/app_store/errors.rb
@@ -141,6 +141,18 @@ def as_json
     end
   end
 
+  class PhasedReleaseAlreadyFinalError < StandardError
+    MSG = "The current phased release is already finished"
+
+    def initialize(msg = MSG)
+      super
+    end
+
+    def as_json
+      AppStore.error_as_json(:release, :phased_release_already_final, MSG)
+    end
+  end
+
   class PhasedReleaseNotFoundError < StandardError
     MSG = "The current live release does not have a staged rollout"
 
@@ -231,13 +243,15 @@ def as_json
     end
   end
 
+  # 404
   NOT_FOUND_ERRORS = [
     AppStore::AppNotFoundError,
     AppStore::BuildNotFoundError,
     AppStore::BetaGroupNotFoundError,
     AppStore::LocalizationNotFoundError
   ]
 
+  # 422
   ERRORS = [
     AppStore::ExportComplianceNotFoundError,
     AppStore::BuildSubmissionForReviewNotAllowedError,
@@ -251,5 +265,11 @@ def as_json
     AppStore::VersionNotEditableError
   ]
 
-  CONFLICT_ERRORS = [AppStore::PhasedReleaseAlreadyInStateError, AppStore::ReleaseNotEditableError, AppStore::ReleaseAlreadyHaltedError]
+  # 409
+  CONFLICT_ERRORS = [
+    AppStore::PhasedReleaseAlreadyInStateError,
+    AppStore::PhasedReleaseAlreadyFinalError,
+    AppStore::ReleaseNotEditableError,
+    AppStore::ReleaseAlreadyHaltedError
+  ]
 end
diff --git a/spaceship/wrapper_error.rb b/spaceship/wrapper_error.rb
@@ -6,27 +6,27 @@ class WrapperError
         decorated_exception: AppStore::BuildSubmissionForReviewNotAllowedError
       },
       {
-        message_matcher: /You cannot update when the value is already set. - \/data\/attributes\/usesNonExemptEncryption/,
+        message_matcher: %r{You cannot update when the value is already set. - /data/attributes/usesNonExemptEncryption},
         decorated_exception: AppStore::ExportComplianceAlreadyUpdatedError
       },
       {
-        message_matcher: /The phased release already has this value - \/data\/attributes\/phasedReleaseState/,
+        message_matcher: %r{The phased release already has this value - /data/attributes/phasedReleaseState},
         decorated_exception: AppStore::PhasedReleaseAlreadyInStateError
       },
       {
         message_matcher: /You cannot create a new version of the App in the current state/,
         decorated_exception: AppStore::VersionAlreadyAddedToSubmissionError
       },
       {
-        message_matcher: /The version number has been previously used. - \/data\/attributes\/versionString/,
+        message_matcher: %r{The version number has been previously used. - /data/attributes/versionString},
         decorated_exception: AppStore::VersionAlreadyExistsError
       },
       {
-        message_matcher: /An attribute value is not acceptable for the current resource state. - The attribute 'versionString' can not be modified. - \/data\/attributes\/versionString/,
+        message_matcher: %r{An attribute value is not acceptable for the current resource state. - The attribute 'versionString' can not be modified. - /data/attributes/versionString},
         decorated_exception: AppStore::VersionNotEditableError
       },
       {
-        message_matcher: /A relationship value is not acceptable for the current resource state. - The specified pre-release build could not be added. - \/data\/relationships\/build/,
+        message_matcher: %r{A relationship value is not acceptable for the current resource state. - The specified pre-release build could not be added. - /data/relationships/build},
         decorated_exception: AppStore::VersionNotEditableError
       },
       {
@@ -40,8 +40,12 @@ class WrapperError
       {
         message_matcher: /Attachment uploads still in progress/i,
         decorated_exception: AppStore::AttachmentUploadInProgress
+      },
+      {
+        message_matcher: /You cannot change the state of a phased release that is in a final state/i,
+        decorated_exception: AppStore::PhasedReleaseAlreadyFinalError
       }
-    ]
+    ].freeze
 
     def self.handle(exception)
       new(exception).handle