Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoring files #54

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alxshine
Copy link

Hello hello 👋 😊

This PR implements the feature requested in #32.

The handling of ignoredFiles is very closely modeled on the handling of auditedFiles.

The checkIfAllSiblingFilesAreAudited now checks if the candidate file is either audited or ignored, causing a directory full of ignored files to be seen as audited. This seemed like the simplest way to integrated it into the existing functionality.

In the explorer view, ignored files are indicated in the same color as gitignored files.

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

@fcasal
Copy link
Collaborator

fcasal commented Oct 1, 2024

Hi @alxshine,
I haven't yet reviewed this PR because we want to merge a big refactor of the codebase #48 first.
As a high level comment about the PR I think I would like to handle ignored files using a .weauditignore file -- in a way that if you mark a file as ignored, it would be also added to the .weauditignore file. In that file, you could also specify folders or globing behaviour like you can in .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants