Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bedrock): add event-based instrumentation #2476

Closed
wants to merge 1 commit into from
Closed

feat(bedrock): add event-based instrumentation #2476

wants to merge 1 commit into from

Conversation

gerred
Copy link

@gerred gerred commented Jan 4, 2025 •
edited
Loading

Disregard, working on something and meant to make a draft PR. Sorry for the noise, will have another PR up shortly.

@gerred
feat(bedrock): add event-based instrumentation
782bcab 
Support both legacy attribute-based and new event-based semantic conventions.
- Add use_legacy_attributes config option (defaults to true)
- Add event emission helpers for prompts and completions
- Update all provider span attribute setters to support both modes
- Add tests for both legacy and event-based modes
- Update README with documentation

Fixes #2456
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 4, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@algora-pbc algora-pbc bot mentioned this pull request Jan 4, 2025
Open
21 tasks
@dosubot dosubot bot added documentation Improvements or additions to documentation python Pull requests that update Python code testing labels Jan 4, 2025
@gerred gerred closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋 Bounty claim documentation Improvements or additions to documentation python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerred @CLAassistant