Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect go workspace setup without go.work #13

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

nekomeowww
Copy link
Contributor

Currently, this project isn't contributable or workable after cloned, the Go workspace setup for this project is unavailable and wrong, since it only contains the go.work.sum file with incorrectly defined go.mod which points to internal traceloop-sdk and semconv-ai packages.

This is due to the incorrect configured .gitignore with the line

# Go workspace file
go.work

which ignores the go.work file.

While Go workspace isn't necessarily needed for such library, but I still maintained the content of go.work.sum not to change a lot to prevent potential dependencies breaking and mismatching, or even vendor vulnerabilities. If you would like to, or feel uncomfortable with go.work somehow, I can open up another PR to help to migrate this project into non-Go workspace one.

I added several other common and widely used .gitignore entries for binaries like sample-app, and commonly leaking credentials, as well as the .DS_Store for macOS users.

Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nekomeowww!

@nirga nirga merged commit b515c99 into traceloop:main Dec 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants