fix: incorrect go workspace setup without go.work #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this project isn't contributable or workable after cloned, the Go workspace setup for this project is unavailable and wrong, since it only contains the
go.work.sum
file with incorrectly definedgo.mod
which points to internaltraceloop-sdk
andsemconv-ai
packages.This is due to the incorrect configured
.gitignore
with the linego-openllmetry/.gitignore
Lines 20 to 21 in 5749e84
which ignores the
go.work
file.While Go workspace isn't necessarily needed for such library, but I still maintained the content of
go.work.sum
not to change a lot to prevent potential dependencies breaking and mismatching, or even vendor vulnerabilities. If you would like to, or feel uncomfortable withgo.work
somehow, I can open up another PR to help to migrate this project into non-Go workspace one.I added several other common and widely used
.gitignore
entries for binaries likesample-app
, and commonly leaking credentials, as well as the.DS_Store
for macOS users.