Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grind-timer: stop timer on pause #22

Merged
merged 4 commits into from
Feb 1, 2025
Merged

grind-timer: stop timer on pause #22

merged 4 commits into from
Feb 1, 2025

Conversation

L1teD
Copy link
Contributor

@L1teD L1teD commented Jan 26, 2025

Timer wasn't stopping during the pause, so this fixes it

@cyperdark
Copy link
Collaborator

@kiwec

@kiwec
Copy link
Contributor

kiwec commented Jan 28, 2025

I noticed the "live" timer pauses while the song is loading. Which is accurate, but looks jank on the overlay. Please merge these changes into the PR @L1teD

L1teD#1

grind-timer: improve pause detection
@cyperdark
Copy link
Collaborator

@kiwec are we ready for a merge

@kiwec
Copy link
Contributor

kiwec commented Feb 1, 2025

@kiwec are we ready for a merge

yes

@cyperdark cyperdark merged commit 2af06b0 into tosuapp:master Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants