Fix index class argument name not work

[waketzheng]

Description

Argument name of Index class does not pass to the _get_index_sql function when generating schemas.

Motivation and Context

1. Pass index.name to _get_index_sql
2. Add field_names property to Index class
3. Add unittest for Index with name defined

How Has This Been Tested?

make ci

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added the changelog accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codspeed-hq]

CodSpeed Performance Report

Merging #1856 will not alter performance

_{Comparing waketzheng:refactor-generate-index-sql (cf39f47) with develop (de48e77)}

Summary

✅ 8 untouched benchmarks

[coveralls]

Pull Request Test Coverage Report for Build 12900145277

Details

• 15 of 21 (71.43%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 89.421%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/indexes.py	10	16	62.5%

Totals
Change from base Build 12889066835:	-0.02%
Covered Lines:	6492
Relevant Lines:	7078

---

💛 - Coveralls

[waketzheng]

@henadzit Shall we add index_name and get_sql back to Index class as follows for compatibility:

class Index:
    def index_name(self, schema_generator: "BaseSchemaGenerator", model: "Type[Model]") -> str:
        return self.name or schema_generator._generate_index_name("idx", model, self.field_names)

    def get_sql(self, schema_generator: "BaseSchemaGenerator", model: "Type[Model]", safe: bool) -> str:
        return schema_generator._get_index_sql(
            model, self.field_names, safe, index_name=self.name, index_type=self.INDEX_TYPE, extra=self.extra
        )

[henadzit]

Thanks for fixing this!

@henadzit Shall we add index_name and get_sql back to Index class as follows for compatibility:

class Index:
    def index_name(self, schema_generator: "BaseSchemaGenerator", model: "Type[Model]") -> str:
        return self.name or schema_generator._generate_index_name("idx", model, self.field_names)

    def get_sql(self, schema_generator: "BaseSchemaGenerator", model: "Type[Model]", safe: bool) -> str:
        return schema_generator._get_index_sql(
            model, self.field_names, safe, index_name=self.name, index_type=self.INDEX_TYPE, extra=self.extra
        )

I searched the aerich code base and seems to be used there - this is something that I didn't realize. We probably need to get it back. Let me know if you want to do it yourself or you want me to do it. If you decide to do it yourself, please, leave a comment in the code to note that it is needed for aerich. Thanks!

[waketzheng]

I searched the aerich code base and seems to be used there - this is something that I didn't realize. We probably need to get it back. Let me know if you want to do it yourself or you want me to do it. If you decide to do it yourself, please, leave a comment in the code to note that it is needed for aerich. Thanks!

@henadzit Cloud you review again. I added index_name/get_sql back and use index.get_sql in schema_generator.

[henadzit]

LGTM!