Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vertical scroll bar #116

Merged
merged 3 commits into from
Nov 22, 2024
Merged

remove vertical scroll bar #116

merged 3 commits into from
Nov 22, 2024

Conversation

grmbyrn
Copy link
Collaborator

@grmbyrn grmbyrn commented Nov 14, 2024

  • Remove vertical scroll bar on all routes/(pages) as mentioned here using the following:
.content-preview {
	overflow-y: scroll;
	scrollbar-width: none;
	-ms-overflow-style: none;
	padding-top: 0rem;
}
  • Edit lists on all routes/(pages) to ensure style consistency.

@grmbyrn grmbyrn requested a review from josecelano November 14, 2024 09:47
Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grmbyrn the vertical scroll bar was only hidden:

image

I think this is worse than the previous version because you don't even know what you are scrolling. You must know that moving the mouse wheel inside the article body scrolls the article content. I think that's not obvious. I think we should either:

  1. Scroll with the window bar
  2. Show the div vertical scroll bar

@josecelano josecelano self-requested a review November 19, 2024 07:40
Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grmbyrn now the scroll works fine, but when you click on a TOC item the contents dones not scroll to that section:

image

@grmbyrn grmbyrn mentioned this pull request Nov 21, 2024
@grmbyrn
Copy link
Collaborator Author

grmbyrn commented Nov 21, 2024

Hi @grmbyrn now the scroll works fine, but when you click on a TOC item the contents dones not scroll to that section:

Hi @josecelano I reached out for help on Melt's Discord. The maintainer TGlide helped with this PR which I used for my most recent commit.

I also spoke to Chris the core maintainer for Skeleton as I tried to implement their solution. He told me that they are in the process of phasing out their in-house Table of Contents in v3 and also recommend Melt UI to SvelteKit users in their new docs.

@da2ce7
Copy link
Contributor

da2ce7 commented Nov 21, 2024

Hello, @grmbyrn in the latest comment please put @TGlide as the author. (yourself as the committer)

@grmbyrn
Copy link
Collaborator Author

grmbyrn commented Nov 21, 2024

Hello, @grmbyrn in the latest comment please put @TGlide as the author. (yourself as the committer)

Hi @da2ce7 I've changed the last commit to make @TGlide author and myself committer.

@da2ce7
Copy link
Contributor

da2ce7 commented Nov 21, 2024

@grmbyrn unfortunately you didn't get his email correct, the author should be tglide <[email protected]> taken from @TGlide comment.

@grmbyrn
Copy link
Collaborator Author

grmbyrn commented Nov 21, 2024

@grmbyrn unfortunately you didn't get his email correct, the author should be tglide <[email protected]> taken from @TGlide comment.

Hi @da2ce7 I've made that change so now Author: TGlide <[email protected]> in git log.

@josecelano
Copy link
Member

ACK 5078729

@josecelano josecelano merged commit 21af551 into torrust:develop Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants