-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove vertical scroll bar #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @grmbyrn the vertical scroll bar was only hidden:
I think this is worse than the previous version because you don't even know what you are scrolling. You must know that moving the mouse wheel inside the article body scrolls the article content. I think that's not obvious. I think we should either:
- Scroll with the window bar
- Show the div vertical scroll bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @grmbyrn now the scroll works fine, but when you click on a TOC item the contents dones not scroll to that section:
Hi @josecelano I reached out for help on Melt's Discord. The maintainer TGlide helped with this PR which I used for my most recent commit. I also spoke to Chris the core maintainer for Skeleton as I tried to implement their solution. He told me that they are in the process of phasing out their in-house Table of Contents in v3 and also recommend Melt UI to SvelteKit users in their new docs. |
@grmbyrn unfortunately you didn't get his email correct, the author should be |
Hi @da2ce7 I've made that change so now |
ACK 5078729 |
routes/(pages)
as mentioned here using the following:routes/(pages)
to ensure style consistency.