Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #130: migrate to svelte 5 and update dependencies
3f22176 remove story:build from workflows (Graeme Byrne) 76d7665 fix readingTime error (Graeme Byrne) eb96c60 fix linting errors (Graeme Byrne) 7b33824 migrate to svelte 5 and update dependencies (Graeme Byrne) Pull request description: * Migrate from Svelte 4 to Svelte 5 as mentioned in this [issue](#106). * Update dependencies in `package.json` such as Vite which were preventing the successful migration to Svelte 5. * Upgrade ESLint to v9 as v8 has recently reached end of life and is no longer maintained, as mentioned [here](https://eslint.org/docs/latest/use/migrate-to-9.0.0). * Upgrade Sass as current syntax is deprecated as mentioned [here](https://sass-lang.com/documentation/breaking-changes/legacy-js-api/) * Remove `/contributors` route as it is redundant since we now display GitHub contributors on home page and on Community page. Existing individual contributor pages have been retained and are accessible by clicking on the author's name in the blog post. * Remove Histoire as it doesn't support Vite at the minute. There is currently a [PR](histoire-dev/histoire#770) open to fix this, so Histoire can be added back later if needed. * When navigating to a new page, the site wouldn't scroll up to the top as would be expected. As found [here](sveltejs/kit#8723), this seems to be a Svelte issue. Solve this by adding the below code to the script block of routes/+layout.svelte and bind to page content: ``` import { onNavigate } from '$app/navigation'; let contentDiv: HTMLElement | null = null; onNavigate((navigation) => { return new Promise((resolve) => { const transition = document.startViewTransition(async () => { if (contentDiv) { // Fix scroll contentDiv.scrollTop = 0; } resolve(); await navigation.complete; }); }); }); ... <div id="app-container"> <Header /> <div bind:this={contentDiv} class="content"> {@render children?.()} <Footer /> </div> </div> ``` ACKs for top commit: josecelano: ACK 3f22176 Tree-SHA512: 09e1042539a441e581eb8cfd759454ac675971acfbf2a0c3fa9eb74693270add836ac2e4864077e09cf29d4cb3be4d232c0dab607685e3f813e2548504ba9cef
- Loading branch information