Allow to use self-signed certificates for OIDC IDP. Correct callback… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…url creation when working behind a proxy
|
Have you checked that this also work if you don't add a self signed cert for verification? |
|
No. I will check and return with results. |
|
I've checked. Yes, it also works. Do you need any proof? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requests lib uses own certificates authority storage. In order to use the self-signed certificate for IDP we need the library to trust it. Add environment variable OIDC_IDP_CA_CERT which points to file with self-signed CA certificate file in PEM-format. Later we add CA certificate to the call arguments of requests.get()