Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compare & merge bug GCounter & PNCounter #73

Merged
merged 6 commits into from
Jul 30, 2024
Merged

fix: compare & merge bug GCounter & PNCounter #73

merged 6 commits into from
Jul 30, 2024

Conversation

joaopereira12
Copy link
Contributor

The compare & merge functions on GCounter & PNCounter don't work properly if the nodes IDs are strings.

d-roak
d-roak reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm whitespaces

packages/crdt/src/builtins/GCounter/index.ts Outdated Show resolved Hide resolved
packages/crdt/src/builtins/GCounter/index.ts Outdated Show resolved Hide resolved
packages/crdt/tests/GCounter.test.ts Outdated Show resolved Hide resolved
packages/crdt/tests/GCounter.test.ts Show resolved Hide resolved
packages/crdt/tests/GCounter.test.ts Outdated Show resolved Hide resolved
packages/crdt/tests/PNCounter.test.ts Outdated Show resolved Hide resolved
d-roak
d-roak reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm whitespaces

packages/crdt/tests/PNCounter.test.ts Outdated Show resolved Hide resolved
packages/crdt/tests/GCounter.test.ts Outdated Show resolved Hide resolved
packages/crdt/tests/GCounter.test.ts Outdated Show resolved Hide resolved
@d-roak d-roak mentioned this pull request Jul 29, 2024
Closed
d-roak
d-roak reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm whitespace

packages/crdt/src/builtins/GCounter/index.ts Outdated Show resolved Hide resolved
@d-roak d-roak merged commit 7ebcbd1 into topology-foundation:main Jul 30, 2024
7 checks passed
@joaopereira12 joaopereira12 deleted the g-counter branch July 30, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaopereira12 @d-roak