merge dev -> main to remove go #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change rpc.go file to get POST and GET request in /rpc endpoint. I think the port should be configurable, but I make pr first so that you guys can review this first --------- Co-authored-by: Jihoon Song <[email protected]>
- all panic code was removed, now errors are sent via channel - shutdown was added to each module to properly handle application panic or manual shutdown
- added gorilla mux router instead of plain http one - refactored network module from files into separate folders per each module - removed mediator because of circular dependency into direct execution module call
closes: #5 - Added custom logger based on ethereum logger (https://github.com/ethereum/go-ethereum/tree/master/log) - Replaced fmt occurrences with the correspondent log
Co-authored-by: Oak <[email protected]>
jihoonsong
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.