-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use protobuf while communicate between peers #30
Merged
t-botclive
merged 8 commits into
topology-foundation:develop
from
Giwook-Han:protobuf-communication
Apr 18, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
37cfa29
use protobuf while communicate between peers
Giwook-Han f90fa7c
mod handling marshaling error
Giwook-Han e4125b7
fix typo
Giwook-Han a9808b5
feat: add custom logger (#25)
d-roak 63cf0b2
use protobuf while communicate between peers
Giwook-Han 0796548
integrate with logger
Giwook-Han be042dd
fix typo
Giwook-Han ae8fc14
Merge branch 'develop' into protobuf-communication
Giwook-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package pbcodec | ||
|
||
type Serializer interface { | ||
Marshal(data interface{}) ([]byte, error) | ||
Unmarshal(data []byte, v interface{}) error | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package pbcodec | ||
|
||
import "google.golang.org/protobuf/proto" | ||
|
||
type ProtoBufSerializer struct{} | ||
|
||
func (p *ProtoBufSerializer) Marshal(data interface{}) ([]byte, error) { | ||
return proto.Marshal(data.(proto.Message)) | ||
} | ||
|
||
func (p *ProtoBufSerializer) Unmarshal(data []byte, v interface{}) error { | ||
return proto.Unmarshal(data, v.(proto.Message)) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, was L221~L224 in affect? I wonder if we still need these after the last refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a node publishes a message, it has already subscribed to the relevant topic. That's why this code needed. no?