Default to no modetation on messages (#19)

* Do not moderate messages sent from server side * Fix tests * Fix tests * Fix tests * Allow moderation if set explicitly * Do not use version on go run
topfreegames · Apr 25, 2024 · 2f0d0ac · 2f0d0ac
1 parent cffb9ae
commit 2f0d0ac
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 9 deletions.
diff --git a/api/sendmqtt.go b/api/sendmqtt.go
@@ -52,6 +52,10 @@ func SendMqttHandler(app *App) func(c echo.Context) error {
 			return FailWith(400, err.Error(), c)
 		}
 
+		if _, exists := msgPayload["should_moderate"]; !exists {
+			msgPayload["should_moderate"] = false
+		}
+
 		topic := c.ParamValues()[0]
 		if err != nil {
 			return FailWith(400, err.Error(), c)

diff --git a/api/sendmqtt_test.go b/api/sendmqtt_test.go
@@ -12,6 +12,7 @@ import (
 	"fmt"
 	"net/http"
 	"net/http/httptest"
+	"strings"
 	"time"
 
 	mqtt "github.com/eclipse/paho.mqtt.golang"
@@ -30,24 +31,37 @@ var _ = Describe("Send to MQTT Handler", func() {
 				testJSON := map[string]interface{}{
 					"message": "hello",
 				}
-				response := `{"topic": "test", "retained": false, "payload": {"message":"hello"}}`
+				response := `{"topic": "test", "retained": false, "payload": {"message":"hello","should_moderate":false}}`
 				status, body := PostJSON(a, "/sendmqtt/test", testJSON)
 
 				Expect(status).To(Equal(http.StatusOK))
-				Expect(body).To(Equal(response))
+				Expect(strings.TrimSpace(body)).To(Equal(strings.TrimSpace(response)))
+			})
+
+			It("Should respond with 200 and not override should_moderate", func() {
+				a := GetDefaultTestApp()
+				testJSON := map[string]interface{}{
+					"message":         "hello",
+					"should_moderate": true,
+				}
+				response := `{"topic": "test", "retained": false, "payload": {"message":"hello","should_moderate":true}}`
+				status, body := PostJSON(a, "/sendmqtt/test", testJSON)
+
+				Expect(status).To(Equal(http.StatusOK))
+				Expect(strings.TrimSpace(body)).To(Equal(strings.TrimSpace(response)))
 			})
 
 			It("Should respond with 200 for a valid message with hierarchical topic", func() {
 				a := GetDefaultTestApp()
 				testJSON := map[string]interface{}{
 					"message": "hello",
 				}
-				response := `{"topic": "test/topic", "retained": false, "payload": {"message":"hello"}}`
+				response := `{"topic": "test/topic", "retained": false, "payload": {"message":"hello","should_moderate":false}}`
 				url := "/sendmqtt/test/topic"
 				status, body := PostJSON(a, url, testJSON)
 
 				Expect(status).To(Equal(http.StatusOK))
-				Expect(body).To(Equal(response))
+				Expect(strings.TrimSpace(body)).To(Equal(strings.TrimSpace(response)))
 			})
 
 			It("Should respond with 400 if malformed JSON", func() {
@@ -66,11 +80,11 @@ var _ = Describe("Send to MQTT Handler", func() {
 					"message": "hello",
 				}
 				topic := uuid.NewV4().String()
-				expectedMsg := `{"message":"hello"}`
+				expectedPayload := `{"message":"hello","should_moderate":false}`
 				response := fmt.Sprintf(
 					`{"topic": "%s", "retained": true, "payload": %s}`,
 					topic,
-					expectedMsg,
+					expectedPayload,
 				)
 				url := fmt.Sprintf("/sendmqtt/%s?retained=true", topic)
 				status, body := PostJSON(a, url, testJSON)
@@ -89,20 +103,20 @@ var _ = Describe("Send to MQTT Handler", func() {
 
 				Expect(msg).NotTo(BeNil())
 				Expect(msg.Retained()).To(BeTrue())
-				Expect(string(msg.Payload())).To(Equal(expectedMsg))
+				Expect(string(msg.Payload())).To(Equal(expectedPayload))
 			})
 
 			It("Should respond with 200 for a valid message with hierarchical topic", func() {
 				a := GetDefaultTestApp()
 				testJSON := map[string]interface{}{
 					"message": "hello",
 				}
-				response := `{"topic": "test/topic", "retained": true, "payload": {"message":"hello"}}`
+				response := `{"topic": "test/topic", "retained": true, "payload": {"message":"hello","should_moderate":false}}`
 				url := "/sendmqtt/test/topic?retained=true"
 				status, body := PostJSON(a, url, testJSON)
 
 				Expect(status).To(Equal(http.StatusOK))
-				Expect(body).To(Equal(response))
+				Expect(strings.TrimSpace(body)).To(Equal(strings.TrimSpace(response)))
 			})
 
 			It("Should respond with 400 if malformed JSON", func() {