Merge pull request #35 from mvanduijker/main

Fix tty not read/writable on build command inside Docker
tonysm · Oct 15, 2024 · e1ce45e · e1ce45e
2 parents c5e520a + 91d3303
commit e1ce45e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Commands/BuildCommand.php b/src/Commands/BuildCommand.php
@@ -6,6 +6,7 @@
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Facades\Process;
 use Tonysm\TailwindCss\Manifest;
+use Symfony\Component\Process\Process as SymfonyProcess;
 
 class BuildCommand extends Command
 {
@@ -48,7 +49,7 @@ public function handle()
         }
 
         Process::forever()
-            ->tty(PHP_OS != 'WINNT' && is_writable('/dev/tty'))
+            ->tty(SymfonyProcess::isTtySupported())
             ->path(base_path())
             ->run(array_filter([
                 $binFile,

diff --git a/src/Commands/InstallCommand.php b/src/Commands/InstallCommand.php
@@ -7,6 +7,7 @@
 use Illuminate\Support\Facades\Process;
 use Illuminate\Support\Str;
 use Symfony\Component\Process\PhpExecutableFinder;
+use Symfony\Component\Process\Process as SymfonyProcess;
 use Tonysm\TailwindCss\Actions\AppendTailwindTag;
 
 class InstallCommand extends Command
@@ -53,7 +54,7 @@ private function ensureTailwindConfigExists()
     private function ensureTailwindCliBinaryExists()
     {
         if (! File::exists(config('tailwindcss.bin_path')) || $this->option('download')) {
-            Process::forever()->tty(PHP_OS != 'WINNT' && is_writable('/dev/tty'))->run([
+            Process::forever()->tty(SymfonyProcess::isTtySupported())->run([
                 $this->phpBinary(),
                 'artisan',
                 'tailwindcss:download',
@@ -168,7 +169,7 @@ private function addIngoreLines()
 
     private function runFirstBuild()
     {
-        Process::forever()->tty(PHP_OS != 'WINNT' && is_writable('/dev/tty'))->run([
+        Process::forever()->tty(SymfonyProcess::isTtySupported())->run([
             $this->phpBinary(),
             'artisan',
             'tailwindcss:build',