Clear memory breakpoints if quitting from the debugger #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uae_quit() doesn't instantly exit, but sets a flag to exit soon. This flag is checked at regular intervals (I believe) If a memory breakpoint is hit before the flag is checked, the debugger opens up rather than letting it quit. By calling deinitialize_memwatch(), the memory breakpoints won't cause problems. Not sure if this affects code breakpointsm but my change wouldn't fix that. deinitialize_memwatch() could maybe be called from within uae_quit, but I'm not confident in the side effects.
|
I think it is better to check in "void debug(void)" if quit_program is set and immediately exit. This would work in all situations and also prevent all ways to enter the debugger during "exit phase" (which also includes "Restart" GUI button) But I'll wait until custom chipset emulation rewrite is complete, lots of things will be internally different compared to 5.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uae_quit() doesn't instantly exit, but sets a flag to exit soon. This flag is checked at regular intervals (I believe) If a memory breakpoint is hit before the flag is checked, the debugger opens up rather than quitting gracefully. By calling deinitialize_memwatch(), the memory breakpoints won't cause problems. Not sure if this is also a problem with code breakpoints as well, but if it is then my code doesn't fix that
deinitialize_memwatch() could maybe be called from within uae_quit, but I'm not confident in the side effects hence the simplest solution.