Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[abi]:add elector and tonstakers abi json #43

Open
wants to merge 2 commits into
base: v0.4.2-dev
Choose a base branch
from

Conversation

fishTsai20
Copy link

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove this file.

@iam047801
Copy link
Collaborator

Thank you. I will test it and merge it.

@iam047801 iam047801 changed the base branch from main to v0.4.2-dev October 15, 2024 10:33
@iam047801
Copy link
Collaborator

Also need to resolve conflicts with v0.4.2-dev branch.

{
"name": "controller_data",
"tlb_type": "^ControllerData",
"format": "controller_data"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No definition for this structure.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment8191

"EQBfBWT7X2BHg9tXAxzhz2aKiNTU1tpt5NsiK0uSDW_YAJ67"
],
"definitions": {
"pool_params": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure from DeDust is not used here.

{
"name": "response_address",
"tlb_type": "MsgAddress",
"format": "msg_address"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For address, should use addr in both format and tlb_type fields.

},
{
"name": "optimistic_deposit_withdrawals",
"tlb_type": "Bool",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tlb_type should be bool.

{
"name": "governor_update_after",
"tlb_type": "## 48",
"format": "uint48"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint48 is not supported. Use uint64.

{
"name": "total_balance",
"stack_type": "int",
"format": "uint"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint is not supported.

},
{
"name": "amount",
"tlb_type": "Coins",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tlb_type here should probably be ..

},
{
"name": "after_upgrade",
"tlb_type": "(Maybe ^Cell)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use maybe ^ instead.

]
},
{
"name": "get_pool_params",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_pool_addr and get_pool_params are copied from DeDust ABI and should not be here.

]
},
{
"interface_name": "tonstakers_controller",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface should have either code, get_methods or addresses.

"format": "int"
}
],
"parameters": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no field parameters. You can use json schema.

{
"name": "deposit_payout",
"stack_type": "slice",
"format": "slice | null"
Copy link
Collaborator

@iam047801 iam047801 Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such format is not supported. Should probably just use slice instead.

Copy link
Collaborator

@iam047801 iam047801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Described ABI is not working yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants