-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[abi]:add elector and tonstakers abi json #43
base: v0.4.2-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove this file.
Thank you. I will test it and merge it. |
Also need to resolve conflicts with |
{ | ||
"name": "controller_data", | ||
"tlb_type": "^ControllerData", | ||
"format": "controller_data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No definition for this structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment8191
"EQBfBWT7X2BHg9tXAxzhz2aKiNTU1tpt5NsiK0uSDW_YAJ67" | ||
], | ||
"definitions": { | ||
"pool_params": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This structure from DeDust is not used here.
{ | ||
"name": "response_address", | ||
"tlb_type": "MsgAddress", | ||
"format": "msg_address" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For address, should use addr
in both format and tlb_type fields.
}, | ||
{ | ||
"name": "optimistic_deposit_withdrawals", | ||
"tlb_type": "Bool", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tlb_type
should be bool
.
{ | ||
"name": "governor_update_after", | ||
"tlb_type": "## 48", | ||
"format": "uint48" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint48
is not supported. Use uint64
.
{ | ||
"name": "total_balance", | ||
"stack_type": "int", | ||
"format": "uint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint
is not supported.
}, | ||
{ | ||
"name": "amount", | ||
"tlb_type": "Coins", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tlb_type
here should probably be .
.
}, | ||
{ | ||
"name": "after_upgrade", | ||
"tlb_type": "(Maybe ^Cell)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use maybe ^
instead.
] | ||
}, | ||
{ | ||
"name": "get_pool_params", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_pool_addr
and get_pool_params
are copied from DeDust ABI and should not be here.
] | ||
}, | ||
{ | ||
"interface_name": "tonstakers_controller", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interface should have either code, get_methods or addresses.
"format": "int" | ||
} | ||
], | ||
"parameters": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no field parameters
. You can use json schema.
{ | ||
"name": "deposit_payout", | ||
"stack_type": "slice", | ||
"format": "slice | null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such format is not supported. Should probably just use slice
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Described ABI is not working yet.
No description provided.