Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm support to transports::Either #703

Conversation

platonfloria
Copy link

@platonfloria platonfloria commented Aug 7, 2023

Issue:
'the trait web3::Transport is not implemented for `web3::transports::Either' when used in wasm.

Reason:
wasm Futures do not implement Send, that is required for Transport implementation of Either.
See rustwasm/wasm-bindgen#2833

Solution:
Remove Send requirement for wasm implementation by using LocalBoxFuture.

@platonfloria platonfloria force-pushed the feature/transport-either-to-support-wasm branch from 5d6de98 to c1a749b Compare August 10, 2023 12:39
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate why the transport does not work in wasm currently?
I have to admit I don't fully understand neither the problem nor the solution, so would appreciate some insights in the PR description.

@platonfloria platonfloria force-pushed the feature/transport-either-to-support-wasm branch from c1a749b to d330fbf Compare June 15, 2024 04:41
@platonfloria
Copy link
Author

Can you elaborate why the transport does not work in wasm currently? I have to admit I don't fully understand neither the problem nor the solution, so would appreciate some insights in the PR description.

Done

@tomusdrw tomusdrw closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants