Review of *functionality* of Automated FastCloning Primer Design Pipeline #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents.txt, and noticed algorithm limiation in fastCloningPrimer.py detailed in a TODO message
tommyfuu
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, it seems like everything works which is impressive! Also, it is clear that you put a lot of work into this which is commendable. This is just a review of the functionality of the code, not on coding style. As with any primer design software, it seems that in some cases where FastCloning primers can be made, no primers are outputted (see the edits in lines 23-50 in the file fastCloningPrimer.py). I think this might be an algorithmic issue, but I am not sure. I think it would be great if we could meet up to talk about the algorithm some more. This program looks suuper thorough and looks like you put in a lot of love + effort + care into it. These are just some thoughts I had!
I also edited some of the wording of the readme file and fixed a tiny bug.
Amazing work!