Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add specs/ja/v1.0.0.md for Japanese translation #68

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

juggernautjp
Copy link
Contributor

Latest version (v1.0.0) has not translated to Japanese.
So, I translated TOML v1.0.0 to Japanese and add specs/ja/v1.0.0.md.

Thank you in advance, if you merge the latest Japanese specs.

@cannikin
Copy link
Contributor

cannikin commented Jul 25, 2023

Hello! There's a strange case where the english name of the anchor is appearing in text next to the headings:

image

This isn't present in the other translations, for example Chinese:

image

@TonalidadeHidrica
Copy link
Contributor

I want to take a look at the issue but I cannot yarn dev (on MacOS and node v18). Could you tell me how I can build the website locally? @cannikin

@arp242
Copy link
Contributor

arp242 commented Sep 28, 2023

What problem did you have running it locally @TonalidadeHidrica?

@TonalidadeHidrica
Copy link
Contributor

@arp242 Running yarn dev, I got an error like Error: error:0308010C:digital envelope routines::unsupported. I googled it and figured out that it is happening on webpack and can be temporarily suppressed by NODE_OPTIONS='--openssl-legacy-provider.

Now webpack succeeds, but I got 404 errors no matter what page I access. Am I doing something wrong?

@arp242
Copy link
Contributor

arp242 commented Sep 28, 2023

Yeah, some of the redirects seem broken if only the spec is translated but not the rest of the website.

I don't know why either, I never looked at this repo before today.

But directly accessing e.g. http://localhost:8000/ja/v1.0.0.html should work.

@arp242
Copy link
Contributor

arp242 commented Sep 28, 2023

I guess that's issue #35 (?)

Also: you can click "details" after "Deploy Preview ready!" in the GitHub CI, so seems you don't strictly need to run it locally in the first place: https://deploy-preview-68--toml-io.netlify.app/ja/v1.0.0.html

@cannikin
Copy link
Contributor

@TonalidadeHidrica try a yarn build first, then yarn dev!

@TonalidadeHidrica
Copy link
Contributor

@cannikin Thanks, after running yarn build the built page showed up by directly entering the correct URL! But it seems that yarn dev still does not relfect the updates automatically and I have to run yarn build && yanr serve every single time I make changes... But at least it worked.

@cannikin
Copy link
Contributor

cannikin commented Oct 5, 2023

Yeah if you're changing the specs themselves you'll need to do a build, it has to compile them into the HTML for display. But making changes to the site pages are picked up automatically by yarn dev!

@cannikin cannikin merged commit 3eab479 into toml-lang:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants