Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Typing notification when a whatsapp user start typing... #170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MirzaHasnat
Copy link

Now you can receive window push notification when someone from your chat start typing. however it will only work when your status is visiable to others.

it will work when you are on other tabs of browser, but it will keep your status online on whatsapp

@tomer8007
Copy link
Owner

Thanks, but

  1. Right now it appears that you will also get notifications when the windows is in focus and while you are talking to someone, so this will be annoying
  2. When the tab is not on focus, your status will quickly become unavailable, so where are you keeping the status online in this case? Also people might not want to appear online all the time or are aware of this fact
  3. You are not checking the global enforcing variable you created, so push notifications will always show up regardless of whether or not the checkbox is ticked
  4. In the notification, you show the contact as a JID (phone number) and not a contact name, it'll be better to get the name (I probably did it in other places in the code)
  5. Please try to keep in line with my code style conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants