Using spaCy nlp.pipe
now processes texts sentence-wise, just like for nlp(...)
.
#41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37
Hello!
Pull Request overview
nlp.pipe
now processes texts sentence-wise, just likenlp(...)
.Details
Before this PR, using
nlp(...)
would split the document into sentences before predicting with each sentence separately, whilepipe
would process each document in full. This is both unexpected and can perform worse. For example, see the following scenario:Results in:
Note:
Leonardo da Vinci
is classified as aperson-athlete
three times, because the full text is sent through the model in one go.After this PR, this same script now results in:
Note:
Leonardo da Vinci
is now (correctly) classified according to the context. This is because each of the sentences are sent through the model separately as you would expect.The implementation is a tad messy, as there now isn't a 1-1 mapping between all entities and the docs, but it works well.
Thank you @q-jackboylan for reporting this discrepancy.