Skip to content

Commit

Permalink
FIX skip test on win32+py38+ failing due to joblib#279
Browse files Browse the repository at this point in the history
  • Loading branch information
tomMoral committed Jan 8, 2021
1 parent 4cec662 commit 27c5607
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion tests/test_reusable_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ class TestExecutorDeadLock(ReusableExecutorMixin):
# on workers
(return_instance, (CrashAtPickle,), TerminatedWorkerError, r"SIGSEGV"),
(return_instance, (ExitAtPickle,), SystemExit, None),
(return_instance, (CExitAtPickle,), TerminatedWorkerError, r"EXIT\(0\)"),
(return_instance, (CExitAtPickle,), TerminatedWorkerError,
r"EXIT\(0\)"),
(return_instance, (ErrorAtPickle,), PicklingError, None),
# Check problem occuring while unpickling a task in
# the result_handler thread
Expand Down Expand Up @@ -345,6 +346,16 @@ def test_deadlock_kill(self):
@pytest.mark.parametrize("n_proc", [1, 2, 5, 13])
def test_crash_races(self, n_proc):
"""Test the race conditions in reusable_executor crash handling"""

if (sys.platform == 'win32' and sys.version_info >= (3, 8)
and n_proc > 5):
pytest.skip(
"On win32, the paging size can be too small to import numpy "
"multiple times in the sub-processes (imported when loading "
"this file). Skipping while no better solution is found. See "
"https://github.com/joblib/loky/issues/279 for more details."
)

# Test for external crash signal comming from neighbor
# with various race setup
executor = get_reusable_executor(max_workers=n_proc, timeout=None)
Expand Down

0 comments on commit 27c5607

Please sign in to comment.