Skip to content

Commit

Permalink
Do not check the format of SASS files with stylelint (#56)
Browse files Browse the repository at this point in the history
We have to combine `postcss-sass` with `stylelint` to format SASS files,
but `postcss-sass` is no longer maintained.
See AleshaOleg/postcss-sass#175.
  • Loading branch information
toku-sa-n authored Dec 8, 2022
1 parent ad84c8e commit 91acf89
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 30 deletions.
27 changes: 3 additions & 24 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# TODO: Check the CSS format. `stylelint` is not usable as `postcss-sass` is
# not maintained anymore.
# See https://github.com/AleshaOleg/postcss-sass/issues/175.
name: Deploy

on:
Expand Down Expand Up @@ -25,29 +28,6 @@ jobs:
name: webpage
path: public/*

# There is an action called `reviewdog/action-stylelint`. However, it requires `package.json` even if a project is not managed by npm.
# That is why I install and run stylelint manually.
check_css:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2

- name: Get the npm cache directory
id: npm-cache-dir
run: echo "::set-output name=dir::$(npm config get cache)"

- uses: actions/cache@v3
with:
path: ${{ steps.npm-cache-dir.outputs.dir }}
key: ${{ runner.os }}-stylelint

- name: Install stylelint
run: npm install stylelint postcss-sass --location=global

- name: Run stylelint
run: stylelint sass/**/*

check_head_and_body_concatenation:
runs-on: ubuntu-latest

Expand Down Expand Up @@ -116,7 +96,6 @@ jobs:
runs-on: ubuntu-latest

needs: [ build
, check_css
, check_head_and_body_concatenation
, check_python_file_format
, check_translations
Expand Down
6 changes: 0 additions & 6 deletions .stylelintrc.json

This file was deleted.

0 comments on commit 91acf89

Please sign in to comment.