core: add struct for recording errors #3113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mladedav
reviewed
Oct 21, 2024
| @@ -270,6 +273,12 @@ pub struct DisplayValue<T: fmt::Display>(T); | |||
| #[derive(Clone)] | |||
| pub struct DebugValue<T: fmt::Debug>(T); | |||
|
|
|||
| /// A 'Value' which serializes error and it's sources. | |||
There was a problem hiding this comment.
Suggested change
| /// A 'Value' which serializes error and it's sources. | |
| /// A `Value` which serializes error and its sources. |
There was a problem hiding this comment.
Also I'm not sure we should talk about sources here. What will be recorded is subscriber-specific, it can completely ignore the sources.
| @@ -658,6 +678,20 @@ impl<T: fmt::Debug> fmt::Debug for DebugValue<T> { | |||
| } | |||
| } | |||
|
|
|||
| // ===== impl ErrorValue ===== | |||
| #[cfg(feature = "std")] | |||
| impl<T: error::Error + 'static> crate::sealed::Sealed for ErrorValue<'_, T> {} | |||
There was a problem hiding this comment.
Isn't it enought for T to outlive 'a?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
tracing_core::field::{error,ErrorValue}as part of #3067.