Fix CTRL_CLOSE, CTRL_LOGOFF and CTRL_SHUTDOWN on windows #7122
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finomnis
force-pushed
the
fix_windows_signals
branch
from
77cf12e to
6e60886
Compare
…program before it had the chance to react
Finomnis
force-pushed
the
fix_windows_signals
branch
from
6e60886 to
44a84f2
Compare
maminrayej
added
A-tokio
Darksonn
reviewed
Jan 27, 2025
|
|
||
| if event_requires_infinite_sleep_in_handler(ty) { | ||
| loop { | ||
| std::thread::sleep(std::time::Duration::MAX); |
There was a problem hiding this comment.
Suggested change
| std::thread::sleep(std::time::Duration::MAX); | |
| std::thread::park(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7039.
Motivation
According to https://learn.microsoft.com/en-us/windows/console/handlerroutine#remarks, the windows signals
CTRL_CLOSE,CTRL_LOGOFFandCTRL_SHUTDOWNimmediately kill the process upon being handled.The intention is that the handler of those signals performs cleanup tasks, and once completed, it returns and the process is killed.
This behavior is sadly not really compatible with an async system that is based on signals.
Solution
There are multiple possible ways to solve this; the easiest one being to simply never return from the handler thread. This works because Rust calls
ExitProcessafter its main (to my knowledge). I tested it on a project of mine, and it seems to work indeed.