coop: expose coop as a public module
#7116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-current-thread
maminrayej
force-pushed
the
feat/expose-coop
branch
from
274caa1 to
59eca5d
Compare
github-actions
bot
removed
R-loom-sync
Darksonn
reviewed
Jan 22, 2025
github-actions
bot
added
R-loom-current-thread
Darksonn
reviewed
Jan 23, 2025
Darksonn
reviewed
Jan 27, 2025
| //! } | ||
| //! }; | ||
| //! | ||
| //! task::unconstrained(fut).await; |
There was a problem hiding this comment.
If we are moving this, we should use the new path in examples.
Suggested change
| //! task::unconstrained(fut).await; | |
| //! task::coop::unconstrained(fut).await; |
| //! | ||
| //! Documentation for this can be found in the [`tokio::task`] module. | ||
| //! See the "Cooperative scheduling" section in the [task](crate::task#cooperative-scheduling) module. |
There was a problem hiding this comment.
You deleted this section.
| pub use consume_budget::consume_budget; | ||
| pub mod coop; | ||
| #[doc(hidden)] | ||
| #[deprecated] |
There was a problem hiding this comment.
Suggested change
| #[deprecated] | |
| #[deprecated = "Moved to tokio::task::coop::consume_budget"] |
|
|
||
| #[tokio::test] | ||
| async fn test_has_budget_remaining() { | ||
| const BUDGET: usize = 128; |
There was a problem hiding this comment.
Let's avoid duplicating this constant in every test. Could you move it to the top of this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
coopmodule public and exposes thehas_budget_remainingfunction.The motivation for this is to make
select!budget-aware (see #7108). The exposed functionality is also useful when dealing with a combination of budget-aware and non-budget-aware futures.Related to #7111.