Bump MSRV to 1.73 #364
Merged
Bump MSRV to 1.73 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` error: package `generator v0.8.3` cannot be built because it requires rustc 1.77 or newer, while the currently active rustc version is 1.65.0 ```
Hmm...? EDIT: filed Xudong-Huang/generator-rs#68 |
taiki-e
force-pushed
the
taiki-e/msrv
branch
from
bab0b63 to
c66568b
Compare
This was referenced Sep 15, 2024
Merged
Darksonn
approved these changes
Sep 22, 2024
```
error: elided lifetime has a name
--> src/rt/object.rs:202:84
|
202 | pub(super) fn iter_mut<'a, O>(&'a mut self) -> impl DoubleEndedIterator<Item = &mut O>
| -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a`
|
= note: `-D elided-named-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`
error: elided lifetime has a name
--> src/thread.rs:283:51
|
283 | unsafe fn get(&'static self) -> Option<Result<&T, AccessError>> {
| ^ this elided lifetime gets resolved as `'static`
|
help: consider specifying it explicitly
|
283 | unsafe fn get(&'static self) -> Option<Result<&'static T, AccessError>> {
| +++++++
```
```
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item
--> src/rt/object.rs:14:43
|
14 | #[cfg_attr(feature = "checkpoint", derive(Serialize, Deserialize))]
| -^^^^^^^^
| |
| `Store` is not local
| `Serialize` is not local
| move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Store`
|
= note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed
= note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive`
= note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
= note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint
= note: `-D non-local-definitions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(non_local_definitions)]`
= note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tokio-rs/loom/actions/runs/10867411903/job/30156136540#step:4:60
Depend on Xudong-Huang/generator-rs#68