Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee return value of serve, Pt. 2 #3166

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

SabrinaJewson
Copy link
Contributor

See #3164. This PR is the revival of #2895.

Like before, in order to ensure in the type system that errors cannot be returned, the logic of WithGracefulShutdown has been extracted to a separate run function.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jplatte jplatte merged commit 28c6be7 into tokio-rs:main Jan 10, 2025
18 checks passed
@SabrinaJewson SabrinaJewson deleted the serve-return-ii branch January 11, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants