fix(asana): try another approach to fix customer problem #2365
+99
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaraujo
approved these changes
Jan 15, 2025
|
LGTM! How can I test the browser extension locally? The guide says to enable development mode but there's no such option in |
|
Oops, nevermind @askides , you already merged it 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
This PR aim to fix the problem our customer has using Asana integration.
The idea is to try to find another approach to do the same things, adding also some console.debug that could be useful in case for better approach.
I did it completely new from scratch this time dividing the 'MyTasks' page from the 'Projects' page, this way we can be sure that the logic will not get too much complex.
🐛 Recommendations for testing
All changes should be tested across Chrome and Firefox.
Ensure that on asana, you can start the timer from the button, and getting the project and the tags correctly both from any project view and my tasks view.
PS: You can enable debug level logging to see the data resolution directly in console (could be useful to see what our customer see).
📝 Links to relevant issues or information
See this slack thread here.