Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): use feature model #9932

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Feb 3, 2025

No description provided.

@graphite-app graphite-app bot requested review from a team February 3, 2025 11:26
Copy link
Member Author

forehalo commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added app:server test Related to test cases labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 46.03960% with 545 lines in your changes missing coverage. Please review.

Project coverage is 43.98%. Comparing base (3834699) to head (6d444d1).

Files with missing lines Patch % Lines
packages/backend/server/src/core/quota/service.ts 21.64% 181 Missing ⚠️
...ges/backend/server/src/models/workspace-feature.ts 17.04% 73 Missing ⚠️
packages/backend/server/src/models/user-feature.ts 10.38% 69 Missing ⚠️
...ckages/backend/server/src/core/features/service.ts 37.87% 41 Missing ⚠️
...kages/backend/server/src/core/features/resolver.ts 43.63% 29 Missing and 2 partials ⚠️
...ckages/backend/server/src/plugins/payment/quota.ts 3.70% 26 Missing ⚠️
packages/backend/server/src/core/features/types.ts 38.70% 19 Missing ⚠️
.../server/src/core/workspaces/resolvers/workspace.ts 15.78% 16 Missing ⚠️
...ckend/server/src/core/workspaces/resolvers/team.ts 13.33% 13 Missing ⚠️
packages/backend/server/src/core/quota/utils.ts 36.84% 12 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9932      +/-   ##
==========================================
- Coverage   53.76%   43.98%   -9.79%     
==========================================
  Files        2272     2258      -14     
  Lines      103544   102129    -1415     
  Branches    17226    15962    -1264     
==========================================
- Hits        55673    44917   -10756     
- Misses      46489    55867    +9378     
+ Partials     1382     1345      -37     
Flag Coverage Δ
server-test 49.05% <46.03%> (-29.23%) ⬇️
unittest 31.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/use-feature-model branch 2 times, most recently from 6532b1c to 0c28c5b Compare February 3, 2025 14:33
@forehalo forehalo force-pushed the 61/use-feature-model branch from 0c28c5b to 6d444d1 Compare February 3, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants