-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real Time Clock support and examples #334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a huge deal, but probably better to not have an idiom of large(?) struct-copying floating around libtock (said, without checking if we are doing that elsewhere that we shouldn't be..).
Otherwise this looks good, and is just blocked on the kernel interface settling / being merged.
Co-authored-by: Pat Pannuto <[email protected]>
Co-authored-by: Pat Pannuto <[email protected]>
Co-authored-by: Pat Pannuto <[email protected]>
Thank you for the suggestions, I have merged the changes into the project. However, this week I will be unable to test whether this program still runs as expected, since I do not have access to a board with date_time support. I will try to test this again around next week, but otherwise, the requested changes have been updated. |
I checked the example project now, and it works as intended, including the changes that were made to the main tock capsule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this is ready to go once the kernel side is merged. We generally defer libtock merges until the kernel merge lands.
The changes to the main tock repository have been merged. |
Head branch was pushed to by a user without write access
Real Time Clock support and examples
Pull Request Overview
This pull request adds Real Time Clock support for libtock-c apps. Specifically, in libtock folder were added rtc.c and rtc,h, which communicate with the date_time capsule from another pull requst to the main tock repository (tock/tock#3559). Additionally, in the examples folder was added an example rtc app, which firs sets a time and date at the beggining and then prints updated time every second.
Testing Strategy
This pull request was tested by running the example project provided on the nucleo-stm429zi and raspberry pi pico boards.