Remove unnecessary input buffer #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
approved these changes
Jul 20, 2023
alistair23
approved these changes
Jul 20, 2023
ppannuto
added a commit
to tock/tock
that referenced
this pull request
Jul 21, 2023
The send path has two possible failures 1. Userspace forgot to allow a buffer to send from 2. The driver already sending something Previously, we returned ERESERVE in both cases, but (2) should be EBUSY instead, which this corrects. I believe this will explain tock/libtock-c#333
2 tasks
brghena
added a commit
that referenced
this pull request
Jul 21, 2023
bradjc
pushed a commit
that referenced
this pull request
Jul 25, 2023
tyler-potyondy
pushed a commit
to tyler-potyondy/libtock-c
that referenced
this pull request
Mar 13, 2024
Remove unnecessary input buffer
tyler-potyondy
pushed a commit
to tyler-potyondy/libtock-c
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the USB Keyboard HID driver by no longer requiring an input buffer for sending strings or characters. Instead, make a local buffer on the stack and use that. The synchronous function that actually sends a buffer has not been changed.
When testing, I found that
usb_keyboard_hid_send()would sometimes returnERESERVE. This behavior occurs in the original version as well before this commit.ERESERVEmeans either the buffer couldn't be taken, or something else couldn't unwrap (I can't follow that mess). https://github.com/tock/tock/blob/master/capsules/extra/src/usb_hid_driver.rs#L205-L231 However, HID output does appear correctly and the app keeps working, so I guess we can keep ignoring it for now...?