Ability to use custom API endpoint #307
Conversation
tobiasehlert
added
enhancement
|
|
hi @jlestel, Thanks for your pull request! Just of curiosity, is this to be able to send the requests through MyTeslamate towards the Fleet API endpoint or what is the goal? Kind regards, |
There was a problem hiding this comment.
Two things regarding this pull request, what do you think?
- I prefer use the same environment variable names as used in the TeslaMate project for reusability within the setup (pushed in 5b32d3e).
- Would be good to have some info-message at startup that says that the
TESLA_API_HOSTenvironment variable is set and therefore is overriding the API command calls.
Other than that it looks good to me :)
| @@ -122,6 +122,7 @@ Basically the same environment variables for the database, mqqt and timezone nee | |||
| | **MQTT_PASSWORD** | string | | | |||
| | **MQTT_NAMESPACE** | string | | | |||
| | **MQTT_CLIENTID** | string | _4 char random string_ | | |||
| | **TESLA_API_URL** | string | _uses Owner API by default_ | | |||
There was a problem hiding this comment.
| | **TESLA_API_URL** | string | _uses Owner API by default_ | | |
| | **TESLA_API_HOST** | string | _uses Owner API by default_ | |
| @@ -112,9 +112,9 @@ func TeslaMateAPICarsCommandV1(c *gin.Context) { | |||
|
|
|||
| switch getCarRegionAPI(TeslaAccessToken) { | |||
| case ChinaAPI: | |||
| TeslaEndpointUrl = "https://owner-api.vn.cloud.tesla.cn" | |||
| TeslaEndpointUrl = getEnv("TESLA_API_URL", "https://owner-api.vn.cloud.tesla.cn") | |||
There was a problem hiding this comment.
| TeslaEndpointUrl = getEnv("TESLA_API_URL", "https://owner-api.vn.cloud.tesla.cn") | |
| TeslaEndpointUrl = getEnv("TESLA_API_HOST", "https://owner-api.vn.cloud.tesla.cn") |
| default: | ||
| TeslaEndpointUrl = "https://owner-api.teslamotors.com" | ||
| TeslaEndpointUrl = getEnv("TESLA_API_URL", "https://owner-api.teslamotors.com") |
There was a problem hiding this comment.
| TeslaEndpointUrl = getEnv("TESLA_API_URL", "https://owner-api.teslamotors.com") | |
| TeslaEndpointUrl = getEnv("TESLA_API_HOST", "https://owner-api.teslamotors.com") |
Agree on both bullets. |
no I already send commands via myteslamate. the goal is rather to propose an oss mobile application for teslamate via teslamateapi. so if it allows users who have their api command to use it to send commands with teslamateapi. |
As already discussed #255 #292 the official Tesla API will be the only way to send commands.
Using third-party Tesla API providers (or a self-hosted commands proxy) would allow command endpoints to be preserved.
I added an environment variable to allow users to choose their API provider.