Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using an arbitrary program instead of urlview, with command-line args #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Boruch-Baum
Copy link

Many people prefer urlscan to urlview, although urlscan can be agonizingly slow. The PR also sneaks in "better"(?) error messages.

+ The reason I'm labeling this commit as 'strange' is that I found
  this commit UNSTAGED the first time I viewed my local copy of the
  repository! The git config declares the upstream as:

    https://github.com/tmux-plugins/tmux-urlview

  which of course does not have the commit. I have been using this
  tmux environment for years and am only now examining the code, so
  how did this commit get here? I certainly did not put it there.
+ This is upstream PR#23 from github user Erethon
+ Inspired by giuthub users laggardkernel, zethra

+ Extractor program can accept parameter arguments in its config
  definition (eg. 'urlscan -R')

+ Needed to revert prior commit in order to support shell idiom %%

  + This should not have been the case, as sh does support %%. I
    don't know why it always failed in my testing.
@bhean
Copy link

bhean commented Jun 27, 2023

That's exactly what I was looking for! I need to use a custom "URL opener" and this is the best way to do it.
Please, review&merge this PR!
Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants