Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a certificate bundle with TLDR_CERT #243

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jtcbrule
Copy link

This pull request makes it possible to specificy a different certificate store/bundle by setting:

  • TLDR_CERT=/path/to/certificates.crt

This is a more secure alternative to disabling SSL verification entirely when behind an SSL proxy.

tldr.py Outdated Show resolved Hide resolved
tldr.py Show resolved Hide resolved
Use pathlib instead of os.path

Co-authored-by: Vítor Henrique <[email protected]>
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome to tldr and thanks for your contribution.


If possible can you fix this linter error?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants