feat: add BSD and macos platforms to --platform option
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
force-pushed
the
feature/bsd-platforms
branch
from
c207191
to
0c84a8d
Compare
owenvoke
force-pushed
the
feature/bsd-platforms
branch
from
0c84a8d
to
8d0905e
Compare
owenvoke
changed the title
--platform option--platform option
kbdharun
approved these changes
Feb 26, 2024
|
This doesn't work, because There's also |
|
Ah, so we need to actually alias it. Will mark this as draft and work on the required changes. I'll add Android as well. I feel like it's a bit redundant duplicating the platforms here though, so perhaps we can extract to a variable or something. |
|
Hi, any updates on this? |
patricedenis
added a commit
to patricedenis/tldr-python-client
that referenced
this pull request
Jun 26, 2024
tldr-pages#236 add aliases to OS_DIRECTORY variable
|
Completed in #246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234 and closes #235