Fix bug where Tinty won't update local templates with custom schemes #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
tinty generate-schemehas been used or custom schemes are added to~/.local/share/tinted-theming/tinty/custom-schemesandtinty applyis run, apply behaves differently: Instead of just applying the theme, it builds each template first (usingtinted-builder-rust). This is necessary to be able to have custom schemes exist for templates.Currently
tinty updatechecks to see if there are any diffs, if there are it does not update and asks the user to remove all of their changes to the repo first. This is where the problem lies since the templates contain themes that aren't in the git history so tinty won't update when custom schemes are used.The change in this PR changes the diff check to allow untracked files since there is low risk of a conflict with a git pull in that case.