Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tinty config subcommand to add config related information #24

Merged
merged 4 commits into from
May 7, 2024

Conversation

JamyGolden
Copy link
Member

@JamyGolden JamyGolden commented May 4, 2024

tinty config with the relevant flags --config-path and --data-path can be useful when debugging to make sure that the expected config is applied and the expected config and data directories are being used by Tinty.

#21

@JamyGolden JamyGolden requested a review from a team as a code owner May 4, 2024 16:01
@JamyGolden JamyGolden requested review from tinted-theming-bot and removed request for a team May 4, 2024 16:01
@laenzlinger
Copy link

looks good to me

maybe a --config-file could be even more useful for a user to directly edit the file

vi $(tinty config --config-file)

README.md Outdated Show resolved Hide resolved
@JamyGolden
Copy link
Member Author

JamyGolden commented May 4, 2024

There are 3 sets of functionality with this:

  • tinty config - prints the config.yml file
  • tinty config --config-path - prints the path to config.yml, so you could vi $(tinty config --config-path)
  • tinty config --data-path - prints the path to the data dir, which on linux is ~/.local/share/tinted-theming/tinty

@JamyGolden JamyGolden force-pushed the jamy/feature/config-subcommand branch from 03a4810 to daed091 Compare May 4, 2024 18:34
Copy link

@laenzlinger laenzlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, so tinty config --config-path returns the full path including the file name. Sorry I misunderstood, i thought it would return the path without the file name.

@JamyGolden
Copy link
Member Author

JamyGolden commented May 7, 2024

Yes, I think I'll change --data-path to --data-dir-path to contrast with --config-path to remove ambiguity of --config-path returning a directory. Thanks for reviewing!

@JamyGolden JamyGolden merged commit 93bd9a9 into main May 7, 2024
1 check passed
@JamyGolden JamyGolden deleted the jamy/feature/config-subcommand branch May 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants