Improve cp calls & fix a typo
#58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat may cause interactive prompts
bezhermoso
requested review from
belak and
mattdavis90
and removed request for
a team
bezhermoso
commented
Oct 23, 2024
| @@ -22,10 +22,6 @@ if [[ -d "$TINTED_JQP_CONFIG_FILE" ]]; then | |||
| return 1 | |||
| fi | |||
|
|
|||
| if [ ! -e "$TINTED_JQP_CONFIG_FILE" ]; then | |||
| touch "$TINTED_JQP_CONFIG_FILE" | |||
| fi | |||
There was a problem hiding this comment.
This wasn't necessary as the theme files from tinted-jqp are just copied over in-place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, the
cp -fflag does not actually prevent it from asking for confirmation. In my case, I havecpaliased tonocorrect cp -i, inducing the prompt. Changing the invocation tocommand cp -f ...forces the shell to use the program instead of any alias that shadowcp.