Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WebApplicationExceptions in VertexResource #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 25, 2014

  1. Allow WebApplicationExceptions in VertexResource

    Several WebApplicationExceptions thrown inside VertexResource methods
    seemed to be unintentionally swallowed by enclosing catch clauses with
    low specificity (e.g. Exception).  These catchall clauses generally
    swallow the WAE's status code and replace it with a generic 500
    internal server error.  This commit changes the catch clauses at the
    bottom of three request methods to allow a WAE to propagate up the
    stack instead of converting it into a generic 500.
    
    This commit also introduces a try-catch with exception logging around
    the RexsterApplicationGraph.tryRollback call made inside several of
    these catch clauses.  The point of this change is to make exceptions
    encountered during rollback get logged and to allow the remainder of
    the catch clause to attempt to execute even if rollback failed.  I ran
    into failing rollbacks when testing Titan 0.5.1-SNAPSHOT against
    Rexster 2.6.0 without defining
    Features.supportsThreadIsolatedTransactions, but I was blind to that
    cause for a while because the exception message and trace were
    suppressed.
    dalaro committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    6183c72 View commit details
    Browse the repository at this point in the history