Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 key features - spacing and sizing fixes #2426

Merged
merged 1 commit into from
Nov 6, 2024
Merged

🐛 key features - spacing and sizing fixes #2426

merged 1 commit into from
Nov 6, 2024

Conversation

joshbermanssw
Copy link
Contributor

@joshbermanssw joshbermanssw commented Nov 6, 2024 •
edited
Loading

As per #2406

The tasks

  • Equal left and right padding on mobile view (figure 1)
  • READ MORE button is to be left aligned on mobile view
  • Headline, body and button to be horizontally aligned on laptop view

Screenshot 2024-11-06 at 10 28 04 am
Figure 1: Equal X padding on mobile

Screenshot 2024-11-06 at 10 26 41 am
Figure 2: Headline, body and button alligned in mobile

Screenshot 2024-11-06 at 10 22 45 am
Figure 3: Cards in laptop view - all items alligned

@joshbermanssw joshbermanssw requested a review from a team as a code owner November 6, 2024 00:09
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:09am

@joshbermanssw joshbermanssw changed the title spacing and sizing fixes 🐛 key features - spacing and sizing fixes Nov 6, 2024
isaaclombardssw
isaaclombardssw approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@joshbermanssw joshbermanssw merged commit 0e8981f into main Nov 6, 2024
3 of 4 checks passed
@joshbermanssw joshbermanssw deleted the re-work-ui-key-features-bug branch November 6, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaclombardssw isaaclombardssw isaaclombardssw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshbermanssw @isaaclombardssw