Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve docs for non-next external-media #1649

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jamespohalloran
Copy link
Contributor

Improve docs for non-next external-media implementations.

One thing to confirm, I removed the NEXT_PUBLIC_ prefix from our environment variables. It doesn't look like these variables are refenced in the tinacms packages, and I don't believe they are needed on the frontend, but could use a second look just to confirm I'm not missing something.

@jamespohalloran jamespohalloran requested a review from a team as a code owner September 5, 2023 14:09
@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 2:09pm

Copy link
Member

@kldavis4 kldavis4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamespohalloran jamespohalloran merged commit ab34863 into master Sep 6, 2023
2 checks passed
@jamespohalloran jamespohalloran deleted the update-agnostic-media-guides branch September 6, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants