Refactor subquery wrapping pipeline #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaVEV
force-pushed
the
refactor-subquery-wrapping-pipeline
branch
from
e2fda19 to
a80f61f
Compare
WaVEV
commented
Jan 9, 2025
| @@ -97,6 +131,7 @@ def register_lookups(): | |||
| field_resolve_expression_parameter | |||
| ) | |||
| In.as_mql = RelatedIn.as_mql = in_ | |||
| In.get_subquery_wrapping_pipeline = get_subquery_wrapping_pipeline | |||
There was a problem hiding this comment.
Range does not need this kind of functionality, it is not allowed by Django.
https://github.com/mongodb-forks/django/blob/mongodb-5.0.x/django/db/models/query.py#L1969
timgraham
reviewed
Jan 9, 2025
| ] | ||
| if wrapping_result_pipeline: | ||
| if get_wrapping_pipeline: | ||
| wrapping_result_pipeline = get_wrapping_pipeline( |
There was a problem hiding this comment.
I think the comment could be included here, rather than redundantly in each get_subquery_wrapping_pipeline(), e.g.
# The results from some lookups must be converted to a list of values.
# The output is compressed with an aggregation pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.