Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.1 release sync #316

Merged
merged 2 commits into from
Aug 1, 2024
Merged

v0.1.1 release sync #316

merged 2 commits into from
Aug 1, 2024

Conversation

bekauz
Copy link
Collaborator

@bekauz bekauz commented Jul 29, 2024

incorporates the astroport tokenfactory-based liquid pooler contract into the main branch

@bekauz bekauz requested review from stiiifff and keyleu July 29, 2024 18:33
To ensure that the tests are working as expected, make sure to confirm the
checksum between the contract that results from wasm optimization in this repo
and the one in `release/v0.1.1` matches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,3 @@
[alias]
wasm = "build --release --lib --target wasm32-unknown-unknown"
schema = "run --bin schema"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming this to config.toml and modifying 'schema' by name of contract would make it consistent with main (and not get warning)

@keyleu
Copy link
Contributor

keyleu commented Jul 30, 2024

One question, right now in this state the contract would not be compatible with covenants in main branch because it doesn't have the op_mode, this will be done later I guess?

@stiiifff
Copy link
Contributor

stiiifff commented Aug 1, 2024

One question, right now in this state the contract would not be compatible with covenants in main branch because it doesn't have the op_mode, this will be done later I guess?

Yes, we will update it with the op_mode. I created an issue for that.

@stiiifff
Copy link
Contributor

stiiifff commented Aug 1, 2024

@bekauz @keyleu Anything missing or this can be merged ?

@bekauz bekauz merged commit 7f613e6 into main Aug 1, 2024
5 checks passed
@bekauz bekauz deleted the benskey/0.1.1-sync branch August 1, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants