astro liquid pooler tokenfactory #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyleu
reviewed
Jul 26, 2024
All good points but I'm tempted to keep those parts of the pr as they are to have the code as close to the v0.1.0 release astro liquid pooler. @stiiifff wdyt? |
stiiifff
approved these changes
Jul 29, 2024
bekauz
changed the title
|
proof that test pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first stab at #312
for review I suggest:
contracts/astroport-tf-liquid-pooler/src/contract.rsagainstcontracts/astroport-liquid-pooler/src/contract.rs(fromv0.1.0tag) to see the contract logic changeslocal-interchaintest/src/tests/single_party_pol/single_party_pol_stride.rsagainst the same file on themainbranch to see the e2e test adjustments