Remove some dead code from downgrade script generation #7623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7623 +/- ##
==========================================
+ Coverage 80.06% 81.31% +1.24%
==========================================
Files 190 240 +50
Lines 37181 44700 +7519
Branches 9450 11159 +1709
==========================================
+ Hits 29770 36348 +6578
- Misses 2997 3968 +971
+ Partials 4414 4384 -30 ☔ View full report in Codecov by Sentry. |
svenklemm
changed the title
svenklemm
force-pushed
the
downgrade_obsolete
branch
from
98428ab to
8c6b7ec
Compare
Since we only support generating downgrade script for the previous version anything targeting versions before 2.18 will never be executed in current context. So we can safely remove the code that deals with version before 2.3.
antekresic
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only support generating downgrade script for the previous
version anything targeting versions before 2.18 will never be
executed in current context. So we can safely remove the code that
deals with version before 2.3.
Disable-check: force-changelog-file
Disable-check: approval-count