Add capacity to customize WITH clause options in CREATE MATERIALIZED VIEW via create_continuous_aggregate #58
Conversation
g-langlois
changed the title
g-langlois
changed the title
|
Thanks for adding the details! I"m going to review and test it soon 🤞 |
There was a problem hiding this comment.
Very good! thanks for fixing and updating this!
I hope in the future we also make all keys more dynamic!
I'll be merging it soon. @g-langlois I'll be releasing a new version but first I'd like to double check if any of the other bugs can also be fixed.
| else | ||
| "" | ||
| end | ||
| Timescaledb::ContinuousAggregates.all.find_each do |aggregate| |
There was a problem hiding this comment.
Thanks for the find_each replacement 🧠
In the future, we may think about also adding a order to keep the caggs name alphabetically or just follow the natural order 🤓
There was a problem hiding this comment.
That would be a good idea! Looks like rails order the tables alphabetically in schema.rb, so it would make sense to also order this alphabetically.
There was a problem hiding this comment.
I'm just curious if we should build some advanced query for considering the hierarchical stuff because they'll need to be in the right order 😃
This PR is to add the capacity to customize the
WITHclause options inCREATE MATERIALIZED VIEWviacreate_continuous_aggregate. The options arematerialized_only,finalizedandcreate_group_indexes.Note: In the proposed implementation, if those options are not specified, the defaults from TimescaleDB extension will be used (the defaults have changed between versions).
This PR also add handling of
materialized_onlyandfinalizedin the schema dumper. Unfortunately,create_group_indexesis not handled since there is no safe way to obtain this information (if there is one, please let me know!).