Simplify connection string configuration #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction-string-handling
MetalBlueberry
force-pushed
the
vperez/simplify-connection-string-handling
branch
from
ce85138 to
c36703e
Compare
Signed-off-by: Victor Perez <[email protected]>
alejandrodnm
approved these changes
Dec 10, 2024
| } | ||
|
|
||
| // Overrideable is an interface for defining ways to override PG settings | ||
| // outside of the usual manners (through the connection string/URL or env vars). |
There was a problem hiding this comment.
@MetalBlueberry pgx supports both the key=value and URI right? I'm like 99% sure, just want to double check.
There was a problem hiding this comment.
https://github.com/jackc/pgx/blob/672c4a3a24849b1f34857817e6ed76f6581bbe90/pgconn/config.go#L161
here it is the documentation. It does
MetalBlueberry
deleted the
vperez/simplify-connection-string-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of implementing custom logic to parse connection string, we can rely on jack/pgx library to parse it for us.