Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions check for static primary feature #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thedodd
Copy link
Member

@thedodd thedodd commented Jun 2, 2022

NOTE: this PR is only for verifying CI. The upstream PR takes precedence.

@coveralls
Copy link

coveralls commented Jun 2, 2022

Pull Request Test Coverage Report for Build 2929710125

  • 23 of 27 (85.19%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 99.847%

Changes Missing Coverage Covered Lines Changed/Added Lines %
patroni/ha.py 21 25 84.0%
Totals Coverage Status
Change from base Build 2913748875: -0.04%
Covered Lines: 11072
Relevant Lines: 11089

💛 - Coveralls

@thedodd thedodd force-pushed the feature-static-primaries branch 2 times, most recently from 4a10968 to 66c69a4 Compare August 1, 2022 15:13
@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022

CLA assistant check
All committers have signed the CLA.

@thedodd thedodd force-pushed the feature-static-primaries branch 9 times, most recently from 87d40bf to a8519b0 Compare August 25, 2022 21:29
In essence, this configuration option will ensure that a
Patroni cluster running with a static primary will not demote
the master unnecessarily.

Transient failures to update the leader lock in the DCS will not cause a
demotion when running with a static primary. When running as leader
under normal circumstances, DCS exceptions will not cause a demotion
when running with `static_primary=thisNode`.

Even if replicas are added to the Patroni cluster, Patroni will
be able to protect itself from entering into unsafe states by checking
the value of static_primary. If the configured static_primary is not the
host node, then the replica will refuse to progress to postmaster boot.
If the configuration was dynamic, then the replica will shutdown when
such a state is detected.

Added behavioral tests for static primary feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants